Add with_alpha_factor to BrushRef/Brush
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still using the old format - will follow-up with new standard
waywardmonkeys
approved these changes
Jul 3, 2024
dfrg
reviewed
Jul 4, 2024
| /// Returns the brush with the alpha component multiplied by the specified | ||
| /// factor. | ||
| #[must_use] | ||
| pub fn with_alpha_factor(&self, alpha: f32) -> Self { |
There was a problem hiding this comment.
I think this one should take self by value and perform the modifications in place. This lets the user decide if they want to clone the full brush.
| /// Returns the brush with the alpha component multiplied by the specified | ||
| /// factor. | ||
| #[must_use] | ||
| pub fn with_alpha_factor(&self, alpha: f32) -> Brush { |
There was a problem hiding this comment.
If we make the change suggested above, this one might not be needed. I think it’s probably fine to call to_owned().with_alpha_factor() on a BrushRef.
|
Looks like I was late to the party. I was curious why it wouldn’t let me click approve in the review. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
Follow-up from #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
The key feature is adding
alphatoImage. There were also a couple of other papercuts which I've tweaked