Complete implementation of feature #6

lindgren · Apr 13, 2017 · 3837f43 · 3837f43
1 parent 938f0ea
commit 3837f43
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/main/java/uk/co/lindgrens/stringcalculator/StringCalculator.java b/src/main/java/uk/co/lindgrens/stringcalculator/StringCalculator.java
@@ -8,6 +8,8 @@
 
 public class StringCalculator {
     private static final String DEFAULT_DELIMITER = ",";
+    public static final int VALID_NUMBER_LOWER_BOUND = 0;
+    public static final int VALID_NUMBER_UPPER_BOUND = 1000;
 
     public int add(String numbers) {
         if(numbers.isEmpty()) {
@@ -78,7 +80,7 @@ private void reportNegativeNumber(List<Integer> errors, int num) {
     }
 
     private int calculateNewTotal(int sum, int num) {
-        if(num > 0) {
+        if(num >= VALID_NUMBER_LOWER_BOUND && num <= VALID_NUMBER_UPPER_BOUND) {
             sum +=num;
         }
 

diff --git a/src/test/groovy/StringCalculatorTest.groovy b/src/test/groovy/StringCalculatorTest.groovy
@@ -8,6 +8,7 @@ class StringCalculatorTest extends Specification {
     def setup() {
         stringCalculator = new StringCalculator()
     }
+
     @Unroll
     def "should calculate the sum of numbers"() {
         expect:
@@ -33,4 +34,15 @@ class StringCalculatorTest extends Specification {
         Exception exception = thrown(IllegalArgumentException)
         exception.message == '-1,-2,-3'
     }
+
+    def "should ignore numbers bigger than 1000"() {
+        given:
+        String numbers = '2,1000,1001'
+
+        when:
+        int sum = stringCalculator.add(numbers)
+
+        then:
+        sum == 1002
+    }
 }