MINOR: findbugs should generate XML reports in Jenkins

Author: Colin P. Mccabe <[email protected]> Reviewers: Ismael Juma <[email protected]> Closes apache#2842 from cmccabe/findbugs-xml
liangjiezhu · Apr 21, 2017 · d53e997 · d53e997
1 parent d18de0e
commit d53e997
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -156,17 +156,18 @@ You can run findbugs using:
     ./gradlew findbugsMain findbugsTest -x test
 
 The findbugs warnings will be found in `reports/findbugs/main.html` and `reports/findbugs/test.html` files in the subproject build
-directories. Currently, findbugs warnings do not cause the build to fail.
+directories.  Use -PxmlFindBugsReport=true to generate an XML report instead of an HTML one.
 
 ### Common build options ###
 
-The following options should be set with a `-D` switch, for example `./gradlew -Dorg.gradle.project.maxParallelForks=1 test`.
+The following options should be set with a `-P` switch, for example `./gradlew -PmaxParallelForks=1 test`.
 
-* `org.gradle.project.mavenUrl`: sets the URL of the maven deployment repository (`file://path/to/repo` can be used to point to a local repository).
-* `org.gradle.project.maxParallelForks`: limits the maximum number of processes for each task.
-* `org.gradle.project.showStandardStreams`: shows standard out and standard error of the test JVM(s) on the console.
-* `org.gradle.project.skipSigning`: skips signing of artifacts.
-* `org.gradle.project.testLoggingEvents`: unit test events to be logged, separated by comma. For example `./gradlew -Dorg.gradle.project.testLoggingEvents=started,passed,skipped,failed test`
+* `mavenUrl`: sets the URL of the maven deployment repository (`file://path/to/repo` can be used to point to a local repository).
+* `maxParallelForks`: limits the maximum number of processes for each task.
+* `showStandardStreams`: shows standard out and standard error of the test JVM(s) on the console.
+* `skipSigning`: skips signing of artifacts.
+* `testLoggingEvents`: unit test events to be logged, separated by comma. For example `./gradlew -PtestLoggingEvents=started,passed,skipped,failed test`.
+* `xmlFindBugsReport`: enable XML reports for findBugs. This also disables HTML reports as only one can be enabled at a time.
 
 ### Running in Vagrant ###
 

diff --git a/build.gradle b/build.gradle
@@ -327,8 +327,8 @@ subprojects {
 
   tasks.withType(FindBugs) {
     reports {
-      xml.enabled false
-      html.enabled true
+      xml.enabled (project.hasProperty('xmlFindBugsReport'))
+      html.enabled (!project.hasProperty('xmlFindBugsReport'))
     }
   }
 

diff --git a/jenkins.sh b/jenkins.sh
@@ -17,4 +17,4 @@
 # This script is used for verifying changes in Jenkins. In order to provide faster feedback, the tasks are ordered so
 # that faster tasks are executed in every module before slower tasks (if possible). For example, the unit tests for all
 # the modules are executed before the integration tests.
-./gradlew clean compileJava compileScala compileTestJava compileTestScala checkstyleMain checkstyleTest findbugsMain unitTest integrationTest --no-daemon -Dorg.gradle.project.testLoggingEvents=started,passed,skipped,failed "$@"
+./gradlew clean compileJava compileScala compileTestJava compileTestScala checkstyleMain checkstyleTest findbugsMain unitTest integrationTest --no-daemon -PxmlFindBugsReport=true -PtestLoggingEvents=started,passed,skipped,failed "$@"