Skip to content

Commit

Permalink
Avoid unnecessary call to ParentRunner.createTestClass() for tests no…
Browse files Browse the repository at this point in the history
…t annotated with @RunWith.
  • Loading branch information
kcooney committed May 25, 2017
1 parent de3404d commit efdcb37
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/main/java/org/junit/internal/builders/JUnit4Builder.java
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package org.junit.internal.builders;

import org.junit.runner.Runner;
import org.junit.runners.BlockJUnit4ClassRunner;
import org.junit.runners.JUnit4;
import org.junit.runners.model.RunnerBuilder;

public class JUnit4Builder extends RunnerBuilder {
@Override
public Runner runnerForClass(Class<?> testClass) throws Throwable {
return new BlockJUnit4ClassRunner(testClass);
return new JUnit4(testClass);
}
}
}
3 changes: 2 additions & 1 deletion src/main/java/org/junit/runners/JUnit4.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.junit.runners;

import org.junit.runners.model.InitializationError;
import org.junit.runners.model.TestClass;

/**
* Aliases the current default JUnit 4 class runner, for future-proofing. If
Expand All @@ -19,6 +20,6 @@ public final class JUnit4 extends BlockJUnit4ClassRunner {
* Constructs a new instance of the default runner
*/
public JUnit4(Class<?> klass) throws InitializationError {
super(klass);
super(new TestClass(klass));
}
}

0 comments on commit efdcb37

Please sign in to comment.