Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing module definition in package.json #1247

Closed
mdorda opened this issue Jun 14, 2023 · 1 comment · Fixed by #1248
Closed

Missing module definition in package.json #1247

mdorda opened this issue Jun 14, 2023 · 1 comment · Fixed by #1248

Comments

@mdorda
Copy link
Contributor

mdorda commented Jun 14, 2023

Importing nouislider as ESM does not work correctly for bundlers (eg. rollup). Example:

import { create } from 'nouislider';

create(htmlElement, { ... });

Results into following build time errors:

  • The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
  • "create" is not exported by "node_modules/nouislider/dist/nouislider.js", imported by filename

The problem is that resolving external dependency "nouislider" uses package.json, where path to module is not defined. So instead of using .mjs file the bundler tries to use .js file found in "main" key.

mdorda added a commit to mdorda/noUiSlider that referenced this issue Jun 14, 2023
leongersen pushed a commit that referenced this issue Jun 14, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant