Skip to content

Commit

Permalink
test: fix flaky test-fs-read-buffer-tostring-fail
Browse files Browse the repository at this point in the history
The test is memory intensive and times out occasionally on Raspberry Pi
devices in CI. Successful test runs take about 90 seconds, but the
devices time out after 120 seconds. That's not a lot of headroom. So
let's skip the test on devices that have only modest amounts of memory.

Fixes: nodejs#7042
PR-URL: nodejs#7575
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
  • Loading branch information
Trott committed Jul 9, 2016
1 parent 9fbe456 commit b9b49ee
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions test/parallel/test-fs-read-buffer-tostring-fail.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
'use strict';

const common = require('../common');

if (!common.enoughTestMem) {
const skipMessage = 'intensive toString tests due to memory confinements';
common.skip(skipMessage);
return;
}

const assert = require('assert');
const fs = require('fs');
const path = require('path');
Expand Down

0 comments on commit b9b49ee

Please sign in to comment.