Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of argon2i & argon2id password hash types #158

Closed
wants to merge 1 commit into from

Conversation

brenard
Copy link

@brenard brenard commented Apr 27, 2022

This PR add support of argon2i & argon2id password hash types (hash, detection and verify methods). I made it on the BRANCH-1.2 but I could provide you a PR on master if you're interest. In any case, I could be useful to have it on a the next 1.2 release.

Regards,

# Argon2 crypted passwords
case 'argon2':
if (password_verify($plainpassword, $cryptedpassword))
return true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using one-liner is more readable return password_verify($plainpassword, $cryptedpassword);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using one-liner is more readable return password_verify($plainpassword, $cryptedpassword);

Yes, you're rights. I write it like this to match with the style of this function :

https://github.com/leenooks/phpLDAPadmin/blob/master/lib/functions.php#L2492

I could also provide a commit to fix it in all the function, say me.

leenooks pushed a commit that referenced this pull request Aug 5, 2022
@leenooks leenooks closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants