Suspend threads when installing instrumentation

ldw5821cn · Dec 10, 2017 · a8ab899 · a8ab899
1 parent 4b9a7a6
commit a8ab899
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/libxposed_art.cpp b/libxposed_art.cpp
@@ -200,6 +200,8 @@ void XposedBridge_invalidateCallersNative(JNIEnv* env, jclass, jobjectArray java
     }
 
     // Now instrument the stack to deoptimize methods which are being called right now.
+    ScopedThreadSuspension sts(soa.Self(), kSuspended);
+    ScopedSuspendAll ssa(__FUNCTION__);
     MutexLock mu(soa.Self(), *Locks::thread_list_lock_);
     runtime->GetThreadList()->ForEach([](Thread* thread, void*) SHARED_REQUIRES(Locks::mutator_lock_) {
         Runtime::Current()->GetInstrumentation()->InstrumentThreadStack(thread);

diff --git a/xposed.cpp b/xposed.cpp
@@ -288,7 +288,7 @@ bool shouldIgnoreCommand(int argc, const char* const argv[]) {
         if (mightBeSuperuser && strcmp(argv[i], "--user") == 0)
             return true;
 
-        char* lastComponent = strrchr(argv[i], '.');
+        const char* lastComponent = strrchr(argv[i], '.');
         if (!lastComponent)
             continue;