better argument names for StringContains #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ayush-Devs thank you! Do you mind also please submitting this same change to LFortran (https://github.com/lfortran/lfortran/) to ensure all tests pass there? |
|
Sorry, but I didnt quite understand what do you wanted me to do. I cloned LFortran on my system, only to find that What exactly do I have to do? A more brief answer would be helpful. |
|
@Ayush-Devs: we'll try to sync libasr from LFortran/LPython soon. Right now it's easier if you submit ASR changes via LFortran. If the StringContains is not there, then it either has to be added there, or removed from here. |
|
added StringContains in LFortran. i hope both the prs are ready to be merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2786
Updated the StringContains ASDL definition:
expr left -> expr substr
expr right -> expr str