v5 #91
Merged
v5 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact-native-picker-select into placeholder-updates
robdsoule
reviewed
Oct 18, 2018
src/index.js
Outdated
| @@ -317,23 +338,27 @@ export default class RNPickerSelect extends PureComponent { | |||
| {this.renderTextInputOrChildren()} | |||
| </TouchableWithoutFeedback> | |||
| <Modal | |||
| testID="RNPickerSelectModal" | |||
| {...modalProps} | |||
There was a problem hiding this comment.
Any thoughts on having this destructure happen after our defined modal props?
Having the destructure happen after is more flexible for people using the component, but I could see concerns on it causing unnecessary issues being reported.
| return { | ||
| // TODO: remove style.placeholderColor option in v5 release | ||
| color: this.props.style.placeholderColor || this.props.placeholderTextColor, | ||
| color: placeholderTextColor, |
| setTimeout(() => { | ||
| this.props.onUpArrow(); | ||
| }); | ||
| setTimeout(onUpArrow); |
There was a problem hiding this comment.
This is a good time to add a comment why setTimeout is on these two arrow methods imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90
closes #78
closes #93