-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile: Support building for web #10650
Merged
laurent22
merged 191 commits into
laurent22:dev
from
personalizedrefrigerator:work/mobile-web
Aug 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
191 commits
Select commit
Hold shift + click to select a range
3bd28d2
Partially building web support
personalizedrefrigerator 0861b96
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 7434ac8
Main screen loads
personalizedrefrigerator 85983db
Working note viewer and editor
personalizedrefrigerator 27e50db
Fix linter errors
personalizedrefrigerator 6260956
Fix Firefox startup
personalizedrefrigerator e687363
Styling and sync fixes
personalizedrefrigerator 9794871
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 5a86531
Fix mobile build
personalizedrefrigerator 3c2f34b
Improve styles
personalizedrefrigerator 3dec27e
Fix installing plugins from file & plugin panels
personalizedrefrigerator b6ac625
Scrollbar style adjustments
personalizedrefrigerator 8ef0762
Fix JEX import
personalizedrefrigerator d1d548d
Faster tarExtract
personalizedrefrigerator 78174ee
File system and alert fixes
personalizedrefrigerator 50f5541
WIP: Resource rendering
personalizedrefrigerator e6177bd
Fix note editor error
personalizedrefrigerator 8ce47d6
Fix Dropbox sync fails to download resources
personalizedrefrigerator 0100450
Fix some UI elements too small
personalizedrefrigerator fe03161
Fix randomBytes implementation
personalizedrefrigerator e04935c
GitHub pages deploy
personalizedrefrigerator bfa6da6
Fix test
personalizedrefrigerator 9dd6e8b
Create release builds in CI
personalizedrefrigerator fd9512f
pages deploy: Checkout correct branch
personalizedrefrigerator 2552134
Fix test
personalizedrefrigerator 2aa3e98
Try to handle cross origin isolation failure in a better way
personalizedrefrigerator 6456142
Renderer: Asset loading
personalizedrefrigerator 8a48149
Fix Firefox plugin loading; possible Safari startup fix
personalizedrefrigerator 79a7622
Trying to fix CI
personalizedrefrigerator 6c70d1b
Better handling of case where no document is selected
personalizedrefrigerator eff8a98
Attempt to improve container sizing when loaded in a mobile browser
personalizedrefrigerator b689f94
PWA support
personalizedrefrigerator 1f3b052
Commenting improvements
personalizedrefrigerator f9b7372
Fix attaching images
personalizedrefrigerator 91b3e2e
index.html: Add OpenGraph meta tag
personalizedrefrigerator 0257206
Fix mobile runtime error
personalizedrefrigerator 7d0213f
Fix editing existing images
personalizedrefrigerator 12adcd9
WIP: RSA using crypto.subtle
personalizedrefrigerator 45b9420
Revert "WIP: RSA using crypto.subtle"
personalizedrefrigerator b6d137f
Provide more information about startup errors
personalizedrefrigerator 7a0c432
PWA: Limit which requests are cached
personalizedrefrigerator 0827088
Fix netinfo error when state.details is undefined
personalizedrefrigerator 520ffa6
Fix size of items in sidemenu
personalizedrefrigerator db17369
PWA manifest: Add screenshots
personalizedrefrigerator c59dc98
index.html: Attempt to make room for software keyboard.
personalizedrefrigerator 8b5a660
Handle cache.put errors
personalizedrefrigerator a5115d8
Add og:image meta tag
personalizedrefrigerator 1a1df6e
Fix quotes in more SQL queries
personalizedrefrigerator 8901da5
Trying to fix sync with encryption
personalizedrefrigerator dcdf0c6
Attempt to work around lack of RSA encryption on web
personalizedrefrigerator db9dbe8
Request persistent storage
personalizedrefrigerator 0f59007
Possible better virtual keyboard handling
personalizedrefrigerator 498df3d
Android: Better virtual-keyboard-related layout adjustments
personalizedrefrigerator e1d5597
iOS: Prevent virtual keyboards from covering the markdown toolbar
personalizedrefrigerator 72df71f
Fix JEX import
personalizedrefrigerator fab2813
Fix JEX export
personalizedrefrigerator 39124c2
Fix internal links
personalizedrefrigerator f867e44
Plugin config screen: Fix loading bar too tall
personalizedrefrigerator 9cfd235
Fix inserting new drawings
personalizedrefrigerator bdfe98e
Open PDFs, external links in new tabs
personalizedrefrigerator 7eae6a8
Chrome: Partial support for file system sync
personalizedrefrigerator 33fa25a
Fix file stat objects always have mtime set to 0
personalizedrefrigerator 681cd3b
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 573a0c1
Cleanup after merge
personalizedrefrigerator 40c705e
Chrome: Persist access to file system handles
personalizedrefrigerator a12f18a
Web build: Prefer .ts files to .js files
personalizedrefrigerator 1d0bcd8
Use RN Paper for most alert dialogs
personalizedrefrigerator c4f6018
Prefer native dialogs on iOS
personalizedrefrigerator 7997d5b
Prevent markdown toolbar buttons from dismissing the keyboard. To-do:…
personalizedrefrigerator a22e1a9
Attempt to prevent sidebar and keyboard-related scroll issues
personalizedrefrigerator 936e086
Attempting to fix web accessibility issues
personalizedrefrigerator 28cdc10
Web: Hide biometrics and voice typing settings (not supported on web)
personalizedrefrigerator 4714067
Attempting to improve plugin asset loading
personalizedrefrigerator 63729e8
Fix KaTeX font loading
personalizedrefrigerator 94b8393
Improve keyboard focus handling
personalizedrefrigerator 7fcfb9d
Folder list: Open folder edit dialog on right-click
personalizedrefrigerator b1e6162
Fix dialogs are too small on small screens
personalizedrefrigerator 4f3cb5d
Fix scrolling on the plugin search results screen
personalizedrefrigerator a87d203
Adjust (temporary) loading indicator style
personalizedrefrigerator a6f15af
Allow syncing with a dev-mode copy of Joplin Server
personalizedrefrigerator 02dbbf2
Fix linter errors
personalizedrefrigerator 9d2f7c9
Web/pickDocument -- fix multiple document selection
personalizedrefrigerator b098d29
Camera: On web: Show a file picker
personalizedrefrigerator aeac6b0
Fix long-press -> open on images
personalizedrefrigerator dfa56f1
Web: Fix scrolling markdown toolbar buttons activates them
personalizedrefrigerator d728090
Fix LogScreen not showing logs on web
personalizedrefrigerator 518ccb6
Fix LogScreen share button
personalizedrefrigerator 56f9f9e
LogScreen:Remove unnecessary extraData
personalizedrefrigerator 5f46365
Attempting to fix "InvalidStateError: Context has stopped" on iOS
personalizedrefrigerator 85aad50
Attempting to fix multiple copies of registry.js bundled
personalizedrefrigerator ab276c1
Retry fs-driver startup on failure
personalizedrefrigerator f4d7aa0
Web: Set default resource download mode to "auto"
personalizedrefrigerator ce89729
Remove outdated debug comment
personalizedrefrigerator 05cb0a8
Trying to fix keyboard scroll bug
personalizedrefrigerator 2c3314d
Initial support for single-instance locking
personalizedrefrigerator fca1e62
Refactor multi-client check and service worker
personalizedrefrigerator 722fdeb
Add the closed.html page
personalizedrefrigerator c498b84
Fix image resize logic
personalizedrefrigerator 3b37776
Fix service worker doesn't ensure that only one client is running when
personalizedrefrigerator 6a50bbb
iOS+Safari: Fix note editor scrolls partially out of view when editin…
personalizedrefrigerator c9e36a9
Hide the "share" option on unsupported platforms
personalizedrefrigerator 8d3de99
Fix broken alarm dialog. (Still no support for showing notifications).
personalizedrefrigerator 956e436
Fix downloading plugins on web
personalizedrefrigerator 21ef340
Fix plugin info modal scrolling
personalizedrefrigerator 1b56016
Mark OneDrive as unsupported on web
personalizedrefrigerator d664a45
Add a Content-Security-Policy header
personalizedrefrigerator 92492ad
Use Alert.alert in fewer places
personalizedrefrigerator e41e931
ServiceWorker caching: Don't cache responses from other domains
personalizedrefrigerator cc5bd1f
Web: Fix long press > share
personalizedrefrigerator ec76829
CSP: Allow data-URL images
personalizedrefrigerator 3c6c35b
Fix wrong number of buttons shown for "uninstall plugin" dialog
personalizedrefrigerator 83a9c80
Fix empty space shown where the OneDrive sync option previously was.
personalizedrefrigerator 16c4068
Fix joplin-noteDidUpdate dispatched before some plugins could finish …
personalizedrefrigerator cf12b20
Renderer: Attempt to reduce time before initial scroll is applied
personalizedrefrigerator 90dddac
Refactoring & fix plugin assets not loaded
personalizedrefrigerator a429c50
Hide "copy external link" on web as not supported
personalizedrefrigerator 484c87c
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 7ad7196
Fix the rendered note media player.
personalizedrefrigerator f837506
Code cleanup
personalizedrefrigerator b0c4146
For now, remove the deploy-github-pages.yml workflow
personalizedrefrigerator 2afbca7
Improve share accept error message
personalizedrefrigerator fc5b15c
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 2919d37
Pin versions
personalizedrefrigerator 001087b
Revert debugging changes
personalizedrefrigerator 73c9c95
Enable dev mode when running on localhost, fix tests
personalizedrefrigerator 5df650e
Revert unnecessary testId in DismissibleDialog
personalizedrefrigerator ce1a026
Move iframe wrapper styles out of main ExteendedWebView component
personalizedrefrigerator 64345ad
Remove TODO comment
personalizedrefrigerator 97e3672
console.warn -> logger.info
personalizedrefrigerator 61c881d
Clean up webpack.config.js
personalizedrefrigerator 7fc1797
Revert package upgrades that should be made in separate PRs
personalizedrefrigerator b3d8c2a
For now, disable custom dialogs on Android
personalizedrefrigerator f4bf7a3
Fix if condition
personalizedrefrigerator bd5fd75
Increase the log level in fs-driver-rn.web.worker
personalizedrefrigerator 93ec159
Fix file system sync with an empty directory
personalizedrefrigerator 3579a28
Geolocation support
personalizedrefrigerator 9ddcee3
Refactor main stylesheet into a separate file
personalizedrefrigerator 8ffc2b2
Adjust logic for when the screen size can be adjusted to compensate for
personalizedrefrigerator 2c8077c
Adjust status bar theme correctly on iOS; change style of loading ind…
personalizedrefrigerator 842ac01
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 9ca3a6b
Update yarn.lock
personalizedrefrigerator 074fdbc
Decrease default log level for fs-driver-rn.web.worker
personalizedrefrigerator 9179c0a
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 8691925
Auto-reload dev plugins
personalizedrefrigerator edc0b2d
Re-decrease log level for fs-driver-rn.worker
personalizedrefrigerator 22727cd
Increase permissions in note viewer/plugin webviews
personalizedrefrigerator 556118c
Fix dev plugins are reloaded too frequently
personalizedrefrigerator 347ba0d
Fix notes with not-downloaded resources fail to render
personalizedrefrigerator efec878
Improve dev plugin reload condition
personalizedrefrigerator da7d6ee
Support pasting images
personalizedrefrigerator 60edc10
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator bed9540
Fix tests
personalizedrefrigerator 7cfa425
Update yarn.lock;
personalizedrefrigerator df265aa
Use ExtendedWebView.web as the CI mock for ExtendedWebView & reduce
personalizedrefrigerator 5fd39b2
Fix test warning
personalizedrefrigerator 68cf6c2
Document the build process for the web client
personalizedrefrigerator 5a17e9a
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator e5ee2c0
Clean up after merge
personalizedrefrigerator 2bf310d
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 75c3147
Post-merge cleanup
personalizedrefrigerator 81aa902
Fix tests
personalizedrefrigerator 884e23c
Revert dev plugin support
personalizedrefrigerator f5de0fc
Add beta warning
personalizedrefrigerator ac7ebfe
Use a fallback edit icon on web for drawings -- getImageSourceSync isn't
personalizedrefrigerator 0d901d9
Fix compilation
personalizedrefrigerator 2589469
cache: Use the service worker cache for failed responses, even if not…
personalizedrefrigerator 8323a8e
Android + Chrome: Fix touching buttons in the markdown toolbar dismisses
personalizedrefrigerator 5a08f8e
Accessibility improvements
personalizedrefrigerator 3781af6
Accessibility: Hide views from accessibility that should be hidden,
personalizedrefrigerator 1d7ec28
index.html: Add <meta name="description" ...>
personalizedrefrigerator e4b4dfc
Update commenting and descriptions
personalizedrefrigerator 17895e6
Fix cross origin isolation failed error message is invisible
personalizedrefrigerator 930c0c2
Fix fallback edit icon slightly off-center
personalizedrefrigerator bb69c04
Chrome: Fix unnecessary horizontal editor scrollbar
personalizedrefrigerator 297ca7b
Fix shim.Geolocation.currentPosition not working in Chrome
personalizedrefrigerator e7cba51
Use custom dialogs instead of browser dialogs for shim.showMessageBox
personalizedrefrigerator 832d8a8
Merge remote-tracking branch 'refs/remotes/origin/work/mobile-web' in…
personalizedrefrigerator df40ad6
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 752b627
Hide "enableWebviewDebugging" on web -- unsupported
personalizedrefrigerator 191f349
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 5e05141
Remove unnecessary file and apply suggestions from self-review of code
personalizedrefrigerator da5ad9d
Remove duplicate logger.error
personalizedrefrigerator ec59114
useRerenderHandler: Remove depenency on FsDriverWeb
personalizedrefrigerator 7a28f58
Make comment about fetch not working in some cases more accurate
personalizedrefrigerator 06bd2d7
Remove now-unnecessary eslint-disable-next-line comment
personalizedrefrigerator ffa6930
Remove shim-init logic unnecessarily duplicated between web & rn files
personalizedrefrigerator ea45909
Revert unnecessary new export
personalizedrefrigerator 615017a
Merge remote-tracking branch 'upstream/dev' into work/mobile-web
personalizedrefrigerator 2352eb8
Update yarn.lock
personalizedrefrigerator 8b2f4ff
Remove potentially inaccurate comment
personalizedrefrigerator 5b4eae5
Add technical doc for the web app
personalizedrefrigerator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Geolocation support
- Loading branch information
commit 3579a28811b03beeca44bc7354e952ac641cc7c2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, this is disabled by default because no user-visible reason is shown for why location permission is requested. The "Allow location access" prompt is shown when first creating a new note (after enabling location tracking), but there isn't any context for why Joplin wants to track the user's location.
Currently, however, I don't think the existing mobile app explains why location permissions are being requested. As such, for consistency, it could make sense to remove this different default: