Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: add plugin resources monitor #10629

Closed
wants to merge 20 commits into from

Conversation

DarkFalc0n
Copy link
Contributor

This pull request is concerned with incremental development of the plugin resources monitor feature.

Summary:

  • Added functions to get App Metrics from the electron API and add them to a map using the PID as key.
  • Added OS Process ID in the Plugin object to identify respective metrics later while displaying.
  • Added a polling function to repeatedly update metrics every 5 seconds (optimisation is WIP)

Testing:

  • Manually tested through logging resourceMetric object and comparing it with top command output in linux.

@DarkFalc0n DarkFalc0n marked this pull request as ready for review July 14, 2024 17:52
@laurent22
Copy link
Owner

Hello, we won't be able to merge this pull request at this time, due to various issues such as the use of class components instead of functional components

@laurent22 laurent22 closed this Jul 31, 2024
Repository owner locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants