Desktop: Fix importing completed tasks #10528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| metadata['todo_completed'] = metadata['user_updated_time']; | ||
| metadata['todo_completed'] = metadata['user_updated_time'] ?? Date.now(); |
There was a problem hiding this comment.
Previously, if updated_time wasn't set, todo_completed would be set to undefined. This resulted in tasks being marked as incomplete, even if completed? was set to yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, tasks with
completed?: yeswere imported as incomplete tasks (withcompleted_time: 0). This was caused by incorrect use of JavaScript'sinwith arrays.This pull request fixes an issue observed while testing #10448.
Testing
This pull request adds two new automated tests:
completed?: yesand there is nouser_updated_time.completed?is not present (the note is not a task).is_todois0after importing.The case where
completed?isfalseis tested by'should import file and set all metadata correctly'.