Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement workaround for WebDAV encoding issue on certain servers #10608

Closed
laurent22 opened this issue Jun 16, 2024 · 1 comment · Fixed by #11076
Closed

Implement workaround for WebDAV encoding issue on certain servers #10608

laurent22 opened this issue Jun 16, 2024 · 1 comment · Fixed by #11076
Assignees
@pedr
Labels
bug It's a bug desktop All desktop platforms high High priority issues sync sync related issue v3.1

Comments

@laurent22
Copy link
Owner

laurent22 commented Jun 16, 2024 •
edited
Loading

Operating system

Windows

Joplin version

3.0.0

Desktop version info

No response

Current behaviour

Error:

Last error: Error: href /remote.php/dav/files/[email protected]/Joplin/locks/ not in baseUrl https://nc.nl.tab.digital/remote.php/dav/files/name%40gmail.com/Joplin nor relativeBaseUrl /remote.php/dav/files/name%40gmail.com/Joplin

The current WebDAV driver needs to extract the relative path from the URL however due to the URL being encoded differently in different contexts, it sometimes fails to do so.

We should improve this check by first doing a regular comparison (as we do know) and, if that fails, do another comparison while URL-decoding the URL.

Expected behaviour

No response

Logs

No response
@laurent22 laurent22 added bug It's a bug desktop All desktop platforms sync sync related issue high High priority issues labels Jun 16, 2024
@laurent22 laurent22 added the v3.1 label Sep 6, 2024
@pedr
Copy link
Collaborator

pedr commented Sep 16, 2024

Use https://thegood.cloud/ to test it

@pedr pedr mentioned this issue Sep 17, 2024
Merged
laurent22 pushed a commit that referenced this issue Sep 23, 2024
@pedr
Desktop,Mobile,Cli: Fixes #10608: WebDAV synchronisation not working …
e357668 
…because of URL encoding differences (#11076)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pedr pedr

Labels
bug It's a bug desktop All desktop platforms high High priority issues sync sync related issue v3.1
Projects
None yet
Milestone
No milestone
2 participants
@laurent22 @pedr