Skip to content

Commit

Permalink
[lldb][test] Break early when walking backtrace in concurrent tests
Browse files Browse the repository at this point in the history
We only need to see that 1 frame of the stack is in user code. No need
to carry on looking.

Doing so actually caused a test failure on Armv8 Ubuntu Jammy where
a libc function does not have a display name. I'm sure I'm going to
get stung by this elsewhere, but for this test, breaking early
sidesteps the problem.
  • Loading branch information
DavidSpickett committed Aug 12, 2024
1 parent c876761 commit 513c372
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lldb/packages/Python/lldbsuite/test/concurrent_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,10 @@ def do_thread_actions(
if funcname in f.GetDisplayFunctionName():
thread_has_user_code = True
break

if thread_has_user_code:
break

if thread_has_user_code:
num_threads_with_usercode += 1

Expand Down

0 comments on commit 513c372

Please sign in to comment.