Skip to content

Commit

Permalink
Added option to set custom description for apps
Browse files Browse the repository at this point in the history
  • Loading branch information
pawelmalak committed Dec 7, 2021
1 parent b08181e commit 531ede0
Show file tree
Hide file tree
Showing 7 changed files with 53 additions and 9 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### v2.2.0 (TBA)
- Added option to set custom description for apps ([#201](https://github.com/pawelmalak/flame/issues/201))

### v2.1.1 (2021-12-02)
- Added support for Docker secrets ([#189](https://github.com/pawelmalak/flame/issues/189))
- Changed some messages and buttons to make it easier to open bookmarks editor ([#239](https://github.com/pawelmalak/flame/issues/239))
Expand Down
13 changes: 6 additions & 7 deletions client/src/components/Apps/AppCard/AppCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,23 @@ import { State } from '../../../store/reducers';

interface Props {
app: App;
pinHandler?: Function;
}

export const AppCard = (props: Props): JSX.Element => {
export const AppCard = ({ app }: Props): JSX.Element => {
const { config } = useSelector((state: State) => state.config);

const [displayUrl, redirectUrl] = urlParser(props.app.url);
const [displayUrl, redirectUrl] = urlParser(app.url);

let iconEl: JSX.Element;
const { icon } = props.app;
const { icon } = app;

if (isImage(icon)) {
const source = isUrl(icon) ? icon : `/uploads/${icon}`;

iconEl = (
<img
src={source}
alt={`${props.app.name} icon`}
alt={`${app.name} icon`}
className={classes.CustomIcon}
/>
);
Expand Down Expand Up @@ -54,8 +53,8 @@ export const AppCard = (props: Props): JSX.Element => {
>
<div className={classes.AppCardIcon}>{iconEl}</div>
<div className={classes.AppCardDetails}>
<h5>{props.app.name}</h5>
<span>{displayUrl}</span>
<h5>{app.name}</h5>
<span>{!app.description.length ? displayUrl : app.description}</span>
</div>
</a>
);
Expand Down
20 changes: 18 additions & 2 deletions client/src/components/Apps/AppForm/AppForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export const AppForm = ({ modalHandler }: Props): JSX.Element => {
<ModalForm modalHandler={modalHandler} formHandler={formSubmitHandler}>
{/* NAME */}
<InputGroup>
<label htmlFor="name">App Name</label>
<label htmlFor="name">App name</label>
<input
type="text"
name="name"
Expand All @@ -122,11 +122,27 @@ export const AppForm = ({ modalHandler }: Props): JSX.Element => {
/>
</InputGroup>

{/* DESCRIPTION */}
<InputGroup>
<label htmlFor="description">App description</label>
<input
type="text"
name="description"
id="description"
placeholder="My self-hosted app"
value={formData.description}
onChange={(e) => inputChangeHandler(e)}
/>
<span>
Optional - If description is not set, app URL will be displayed
</span>
</InputGroup>

{/* ICON */}
{!useCustomIcon ? (
// use mdi icon
<InputGroup>
<label htmlFor="icon">App Icon</label>
<label htmlFor="icon">App icon</label>
<input
type="text"
name="icon"
Expand Down
1 change: 1 addition & 0 deletions client/src/interfaces/App.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export interface NewApp {
url: string;
icon: string;
isPublic: boolean;
description: string;
}

export interface App extends Model, NewApp {
Expand Down
1 change: 1 addition & 0 deletions client/src/utility/templateObjects/appTemplate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export const newAppTemplate: NewApp = {
url: '',
icon: '',
isPublic: true,
description: '',
};

export const appTemplate: App = {
Expand Down
19 changes: 19 additions & 0 deletions db/migrations/05_app-description.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
const { DataTypes } = require('sequelize');
const { STRING } = DataTypes;

const up = async (query) => {
await query.addColumn('apps', 'description', {
type: STRING,
allowNull: false,
defaultValue: '',
});
};

const down = async (query) => {
await query.removeColumn('apps', 'description');
};

module.exports = {
up,
down,
};
5 changes: 5 additions & 0 deletions models/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ const App = sequelize.define(
allowNull: true,
defaultValue: 1,
},
description: {
type: DataTypes.STRING,
allowNull: false,
defaultValue: '',
},
},
{
tableName: 'apps',
Expand Down

0 comments on commit 531ede0

Please sign in to comment.