Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows contributors #223

Merged
merged 1 commit into from
Feb 11, 2016
Merged

Support Windows contributors #223

merged 1 commit into from
Feb 11, 2016

Conversation

dougwilson
Copy link
Contributor

Since we cannot invoke Makefiles easily and really, it can just be put in an npmscript.

@dougwilson
Copy link
Contributor Author

I went ahead and rebased this PR so it's mergable again.

@nathanboktae
Copy link

I like this even as a mac user. npm test is more natural.

@dougwilson
Copy link
Contributor Author

Any desire to merge?

@mikelax
Copy link
Contributor

mikelax commented Feb 9, 2016

Thanks @dougwilson. I will go ahead and merge.
I didn't mind the Makefile but for this simple use case npm test is sufficient.

@mikelax mikelax self-assigned this Feb 9, 2016
@mikelax mikelax added this to the 1.2.0 milestone Feb 9, 2016
mikelax added a commit that referenced this pull request Feb 11, 2016
@mikelax
Merge pull request #223 from dougwilson/Windows_tests
96abafa 
Support Windows contributors
@mikelax mikelax merged commit 96abafa into ladjs:master Feb 11, 2016
@dougwilson dougwilson deleted the Windows_tests branch February 15, 2016 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikelax mikelax

Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dougwilson @nathanboktae @mikelax