Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify all zkSync forks into a single monitor #540

Merged
merged 16 commits into from
Jul 12, 2022
Merged

Conversation

sz-piotr
Copy link
Member

Based on work by @sin6pi7 so I'm most excited about your review.

@sin6pi7
Copy link
Contributor

sin6pi7 commented Jul 12, 2022

What was the rationale for going with just typechain over eth-sdk?

@sz-piotr
Copy link
Member Author

What was the rationale for going with just typechain over eth-sdk?

I didn't have the need to use any of eth-sdk functions

@sz-piotr sz-piotr requested a review from sin6pi7 July 12, 2022 08:49
Copy link
Contributor

@sin6pi7 sin6pi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌

@sz-piotr sz-piotr enabled auto-merge (squash) July 12, 2022 08:53
@sz-piotr sz-piotr merged commit 0062d06 into master Jul 12, 2022
@sz-piotr sz-piotr deleted the upgrade-monitor branch July 12, 2022 08:59
shichiro-nakahara pushed a commit to shichiro-nakahara/l2beat that referenced this pull request Dec 18, 2023
* Add a generalized monitor

* Simplify

* More functionality

* Add security council

* Add zkSpace

* Small renames

* Add zkSwap1

* Add zkSwap2

* Remove old monitors

* Update README

* Remove .DS_Store

* Add missing dependencies

* Fix eslint

* Update readme

* Enforce env variable being present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants