Skip to content

Commit

Permalink
rtl8139: fix Pointer to local outside scope
Browse files Browse the repository at this point in the history
Coverity spot:
 Assigning: iov = struct iovec [3]({{buf, 12UL},
                       {(void *)dot1q_buf, 4UL},
                       {buf + 12, size - 12}})
 (address of temporary variable of type struct iovec [3]).
 out_of_scope: Temporary variable of type struct iovec [3] goes out of scope.

Pointer to local outside scope (RETURN_LOCAL)
use_invalid:
 Using iov, which points to an out-of-scope temporary variable of type struct iovec [3].

Signed-off-by: Gonglei <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Jason Wang <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
  • Loading branch information
gongleiarei authored and stefanhaRH committed Nov 21, 2014
1 parent 7b50d00 commit b0af844
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions hw/net/rtl8139.c
Original file line number Diff line number Diff line change
Expand Up @@ -1775,6 +1775,7 @@ static void rtl8139_transfer_frame(RTL8139State *s, uint8_t *buf, int size,
int do_interrupt, const uint8_t *dot1q_buf)
{
struct iovec *iov = NULL;
struct iovec vlan_iov[3];

if (!size)
{
Expand All @@ -1789,6 +1790,9 @@ static void rtl8139_transfer_frame(RTL8139State *s, uint8_t *buf, int size,
{ .iov_base = buf + ETHER_ADDR_LEN * 2,
.iov_len = size - ETHER_ADDR_LEN * 2 },
};

memcpy(vlan_iov, iov, sizeof(vlan_iov));
iov = vlan_iov;
}

if (TxLoopBack == (s->TxConfig & TxLoopBack))
Expand Down

0 comments on commit b0af844

Please sign in to comment.