Skip to content

Commit

Permalink
Remove unused function parameter from cpu_restore_state
Browse files Browse the repository at this point in the history
The previous patch removed the need for parameter puc.
Is is now unused, so remove it.

Cc: Aurelien Jarno <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
  • Loading branch information
Stefan Weil committed Apr 20, 2011
1 parent e87b7cb commit 618ba8e
Show file tree
Hide file tree
Showing 16 changed files with 20 additions and 23 deletions.
2 changes: 1 addition & 1 deletion cpu-exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ static inline int handle_cpu_signal(unsigned long pc, unsigned long address,
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, puc);
cpu_restore_state(tb, env, pc);
}

/* we restore the process signal mask as the sigreturn should
Expand Down
3 changes: 1 addition & 2 deletions exec-all.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ void cpu_gen_init(void);
int cpu_gen_code(CPUState *env, struct TranslationBlock *tb,
int *gen_code_size_ptr);
int cpu_restore_state(struct TranslationBlock *tb,
CPUState *env, unsigned long searched_pc,
void *puc);
CPUState *env, unsigned long searched_pc);
void cpu_resume_from_signal(CPUState *env1, void *puc);
void cpu_io_recompile(CPUState *env, void *retaddr);
TranslationBlock *tb_gen_code(CPUState *env,
Expand Down
9 changes: 4 additions & 5 deletions exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1070,8 +1070,7 @@ void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
restore the CPU state */

current_tb_modified = 1;
cpu_restore_state(current_tb, env,
env->mem_io_pc, NULL);
cpu_restore_state(current_tb, env, env->mem_io_pc);
cpu_get_tb_cpu_state(env, &current_pc, &current_cs_base,
&current_flags);
}
Expand Down Expand Up @@ -1179,7 +1178,7 @@ static void tb_invalidate_phys_page(tb_page_addr_t addr,
restore the CPU state */

current_tb_modified = 1;
cpu_restore_state(current_tb, env, pc, puc);
cpu_restore_state(current_tb, env, pc);
cpu_get_tb_cpu_state(env, &current_pc, &current_cs_base,
&current_flags);
}
Expand Down Expand Up @@ -3266,7 +3265,7 @@ static void check_watchpoint(int offset, int len_mask, int flags)
cpu_abort(env, "check_watchpoint: could not find TB for "
"pc=%p", (void *)env->mem_io_pc);
}
cpu_restore_state(tb, env, env->mem_io_pc, NULL);
cpu_restore_state(tb, env, env->mem_io_pc);
tb_phys_invalidate(tb, -1);
if (wp->flags & BP_STOP_BEFORE_ACCESS) {
env->exception_index = EXCP_DEBUG;
Expand Down Expand Up @@ -4301,7 +4300,7 @@ void cpu_io_recompile(CPUState *env, void *retaddr)
retaddr);
}
n = env->icount_decr.u16.low + tb->icount;
cpu_restore_state(tb, env, (unsigned long)retaddr, NULL);
cpu_restore_state(tb, env, (unsigned long)retaddr);
/* Calculate how many instructions had been executed before the fault
occurred. */
n = n - env->icount_decr.u16.low;
Expand Down
2 changes: 1 addition & 1 deletion target-alpha/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,7 @@ void tlb_fill (target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (likely(tb)) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
/* Exception index and error code are already set */
Expand Down
2 changes: 1 addition & 1 deletion target-arm/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ void tlb_fill (target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
raise_exception(env->exception_index);
Expand Down
2 changes: 1 addition & 1 deletion target-cris/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ void tlb_fill (target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);

/* Evaluate flags after retranslation. */
helper_top_evaluate_flags();
Expand Down
2 changes: 1 addition & 1 deletion target-i386/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -4835,7 +4835,7 @@ void tlb_fill(target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
raise_exception_err(env->exception_index, env->error_code);
Expand Down
2 changes: 1 addition & 1 deletion target-lm32/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ void tlb_fill(target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
cpu_loop_exit();
Expand Down
2 changes: 1 addition & 1 deletion target-m68k/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ void tlb_fill (target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
cpu_loop_exit();
Expand Down
2 changes: 1 addition & 1 deletion target-microblaze/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ void tlb_fill (target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
cpu_loop_exit();
Expand Down
4 changes: 2 additions & 2 deletions target-mips/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ static void do_restore_state (void *pc_ptr)

tb = tb_find_pc (pc);
if (tb) {
cpu_restore_state (tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
#endif
Expand Down Expand Up @@ -1972,7 +1972,7 @@ void tlb_fill (target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
helper_raise_exception_err(env->exception_index, env->error_code);
Expand Down
2 changes: 1 addition & 1 deletion target-ppc/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -3741,7 +3741,7 @@ void tlb_fill (target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (likely(tb)) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
helper_raise_exception_err(env->exception_index, env->error_code);
Expand Down
2 changes: 1 addition & 1 deletion target-s390x/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void tlb_fill (target_ulong addr, int is_write, int mmu_idx, void *retaddr)
if (likely(tb)) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
/* XXX */
Expand Down
2 changes: 1 addition & 1 deletion target-sh4/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ static void cpu_restore_state_from_retaddr(void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, NULL);
cpu_restore_state(tb, env, pc);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion target-sparc/op_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -4375,7 +4375,7 @@ static void cpu_restore_state2(void *retaddr)
if (tb) {
/* the PC is inside the translated code. It means that we have
a virtual CPU fault */
cpu_restore_state(tb, env, pc, (void *)(long)env->cond);
cpu_restore_state(tb, env, pc);
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions translate-all.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,7 @@ int cpu_gen_code(CPUState *env, TranslationBlock *tb, int *gen_code_size_ptr)
/* The cpu state corresponding to 'searched_pc' is restored.
*/
int cpu_restore_state(TranslationBlock *tb,
CPUState *env, unsigned long searched_pc,
void *puc)
CPUState *env, unsigned long searched_pc)
{
TCGContext *s = &tcg_ctx;
int j;
Expand Down

0 comments on commit 618ba8e

Please sign in to comment.