chore(*) remove old Ingress

[jakubdyszkiewicz]

Summary

Remove support for old Ingress embedded in Dataplane. In Kuma 1.2.0 we introduced the ZoneIngress, now it's time to finally get rid of the old ingress.

Issues resolved

Fix #3166

Documentation

• Docs were replaced long time ago.

Testing

• Unit tests
• E2E tests
• Manual testing on Universal
• Manual testing on Kubernetes

Backwards compatibility

• Update UPGRADE.md with any steps users will need to take
  when upgrading.
• Should this be released in Kuma 1.4.1? It is a breaking change but I hope everyone migrated a long time ago.

[codecov-commenter]

Codecov Report

Merging #3435 (3896338) into master (1642741) will increase coverage by 0.09%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master    #3435      +/-   ##
==========================================
+ Coverage   52.20%   52.29%   +0.09%     
==========================================
  Files         939      939              
  Lines       54747    54395     -352     
==========================================
- Hits        28581    28447     -134     
+ Misses      23929    23728     -201     
+ Partials     2237     2220      -17     

Impacted Files	Coverage Δ
api/mesh/v1alpha1/dataplane_helpers.go	85.58% <ø> (+3.84%)	⬆️
pkg/api-server/dataplane_overview_endpoints.go	66.66% <ø> (ø)
...kg/core/resources/apis/mesh/dataplane_validator.go	97.79% <ø> (+3.90%)	⬆️
...kg/core/resources/apis/mesh/generated_resources.go	81.02% <ø> (ø)
...g/core/resources/apis/mesh/zone_ingress_helpers.go	11.42% <ø> (-22.45%)	⬇️
pkg/dns/vips_allocator.go	73.75% <ø> (-0.76%)	⬇️
pkg/kds/context/context.go	52.63% <0.00%> (ø)
pkg/kds/zone/components.go	16.39% <ø> (-0.53%)	⬇️
...ugins/bootstrap/k8s/xds/hooks/api_server_bypass.go	0.00% <0.00%> (ø)
...ns/runtime/k8s/controllers/configmap_controller.go	8.16% <ø> (-5.73%)	⬇️
... and 21 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1642741...3896338. Read the comment docs.

[michaelbeaumont]

Should this be released in Kuma 1.4.1? It is a breaking change but I hope everyone migrated a long time ago.

Is there a reason to remove it in 1.4.1?

[jpeach]

Should this be released in Kuma 1.4.1? It is a breaking change but I hope everyone migrated a long time ago.

Is there a reason to remove it in 1.4.1?

IMHO we should not make breaking changes in point releases.

[lahabana]

Sweet. +1 on not backporting. We can ship this change on 1.5.0.