Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull containerd binaries from gs://k8s-staging-cri-tools bucket #30153

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

upodroid
Copy link
Member

/cc @akhilerm @dims @SergeyKanzhelev

Part of #29995

The bucket is still missing release binaries jobs, it will be populated in 24 hours.

 mahamed  REDACTED  ~  $  gsutil ls gs://k8s-staging-cri-tools/containerd
gs://k8s-staging-cri-tools/containerd/main/

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 21, 2023
@upodroid
Copy link
Member Author

/hold

I'll cancel it once the bucket is populated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2023
@dims
Copy link
Member

dims commented Jul 21, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2023
@upodroid
Copy link
Member Author

There is a snag. Some of the env files are used by containerd/containerd node-e2e presubmits and fixing those jobs to use kubetest2 + migrate to community cluster is hard. Details are at #30159

I can allow the [email protected] service account to write to the community bucket and merge it on Monday.

Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akhilerm
Copy link
Member

While doing gsutil ls gs://k8s-staging-cri-tools/containerd, do you happen to know what are the first 5 entries. Are they related to the PR runs? A bit confused that same item has entry inside the main directory and also in commit hash directory.

gs://k8s-staging-cri-tools/containerd/25d05956080b50b5bdf77d69da4820ee445d8a8b/
gs://k8s-staging-cri-tools/containerd/47be539f2cbc6aebb1a55b9365aaf093e03fb604/
gs://k8s-staging-cri-tools/containerd/5d4c71af23ccb035bf9d59f9badb87776fc7880f/
gs://k8s-staging-cri-tools/containerd/722f8def5a46aa1794c19966cbc3bf0220ef3c26/
gs://k8s-staging-cri-tools/containerd/9e16b5a80a5e37bf8989d3d69c47a07016d61f70/
gs://k8s-staging-cri-tools/containerd/main/
gs://k8s-staging-cri-tools/containerd/release-1.6/
gs://k8s-staging-cri-tools/containerd/release-1.7/

@upodroid
Copy link
Member Author

Those are PRs that were built and used in a containerd/containerd e2e test.

@upodroid
Copy link
Member Author

upodroid commented Jul 24, 2023

As soon as containerd/containerd#8862 is merged, I'll cancel the hold from this build.

We are currently testing 5 commits behind for jobs that test against containerd's HEAD.
https://testgrid.k8s.io/containerd-postsubmits#post-containerd-build

https://github.com/containerd/containerd/compare/6eb90a6..59959b3

@upodroid
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@upodroid
Copy link
Member Author

There is a circular dependancy. The change in containerd doesn't work because the env file still has the old bucket. I'll merge this PR which should allow the e2e tests in containerd/containerd to pass. Merging that PR and cherrypicking the fixes to 1.6 and 1.7 should resolve all the flakes that will be triggered.

@k8s-ci-robot k8s-ci-robot merged commit f56288e into kubernetes:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants