Fastly: use a private bucket as origin for dl.k8s.io #7178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure the VCL service can use a GCS private bucket as origin using AWS auth headers. GCS API is S3-compatible. We apply the snippet from https://quic.fastly.com/documentation/solutions/examples/google-cloud-storage-origin-private/ - Enable Shielding for the service. More informations on https://www.fastly.com/documentation/guides/concepts/shielding/ - Disable the healthcheck for the service. This is not required since we have Origin Inspector activated and is currently not working with the private bucket. Signed-off-by: Arnaud Meukam <[email protected]>
Add data resources that will help get the credentials needed for the VCL to authenticate against GCS API. Signed-off-by: Arnaud Meukam <[email protected]>
k8s-ci-robot
added
the
area/infra
k8s-ci-robot
added
sig/k8s-infra
|
/hold I will deploy this next Monday. |
k8s-ci-robot
added
the
do-not-merge/hold
BenTheElder
reviewed
Aug 15, 2024
There was a problem hiding this comment.
This vaguely looks right? and I trust you. But I'm also no expert here.
/lgtm
/approve
/hold
@BenTheElder reviewing VCL:
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
I think we may need to revert. Seeing failures downloading |
|
|
discussing mitigations in the above slack thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth headers. GCS API is S3-compatible. We apply the snippet from https://quic.fastly.com/documentation/solutions/examples/google-cloud-storage-origin-private/
have Origin Inspector activated and is currently not working with the
private bucket.