Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let K8s TestGrid read config files. #7076

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

michelle192837
Copy link
Contributor

@michelle192837 michelle192837 commented Jul 26, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2024
@ameukam
Copy link
Member

ameukam commented Jul 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@ameukam
Copy link
Member

ameukam commented Jul 27, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit d0a4365 into kubernetes:main Jul 27, 2024
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 27, 2024
@michelle192837
Copy link
Contributor Author

Thanks! Applied ^^

Terraform will perform the following actions:

  # module.testgrid_config_bucket.google_storage_bucket_iam_member.members["roles/storage.objectViewer serviceAccount:[email protected]"] will be created
  + resource "google_storage_bucket_iam_member" "members" {
      + bucket = "k8s-testgrid-config"
      + etag   = (known after apply)
      + id     = (known after apply)
      + member = "serviceAccount:[email protected]"
      + role   = "roles/storage.objectViewer"
    }

  # module.testgrid_config_bucket.google_storage_bucket_iam_member.members["roles/storage.objectViewer serviceAccount:[email protected]"] will be created
  + resource "google_storage_bucket_iam_member" "members" {
      + bucket = "k8s-testgrid-config"
      + etag   = (known after apply)
      + id     = (known after apply)
      + member = "serviceAccount:[email protected]"
      + role   = "roles/storage.objectViewer"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.testgrid_config_bucket.google_storage_bucket_iam_member.members["roles/storage.objectViewer serviceAccount:[email protected]"]: Creating...
module.testgrid_config_bucket.google_storage_bucket_iam_member.members["roles/storage.objectViewer serviceAccount:[email protected]"]: Creating...
module.testgrid_config_bucket.google_storage_bucket_iam_member.members["roles/storage.objectViewer serviceAccount:[email protected]"]: Creation complete after 5s [id=b/k8s-testgrid-config/roles/storage.objectViewer/serviceAccount:[email protected]]
module.testgrid_config_bucket.google_storage_bucket_iam_member.members["roles/storage.objectViewer serviceAccount:[email protected]"]: Still creating... [10s elapsed]
module.testgrid_config_bucket.google_storage_bucket_iam_member.members["roles/storage.objectViewer serviceAccount:[email protected]"]: Creation complete after 10s [id=b/k8s-testgrid-config/roles/storage.objectViewer/serviceAccount:[email protected]]

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

@michelle192837 michelle192837 deleted the tgpermissions branch July 27, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants