Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update root owners with current TLs #6047

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

BenTheElder
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2023
@ameukam
Copy link
Member

ameukam commented Oct 31, 2023

/lgtm
/approve

With great power, come great responsibilities...

cc @thockin

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2023
@upodroid
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@upodroid
Copy link
Member

Can you apply this patch as well please? couple of no_parent_owners without the main alias

 mahamed  MAHAALI-M-2PY9  ~  Desktop  Git  k8s.io   main  4✎  $  git diff main
diff --git a/OWNERS b/OWNERS
index 39ed6d701..64683eb60 100644
--- a/OWNERS
+++ b/OWNERS
@@ -5,12 +5,14 @@ approvers:
 - cblecker # sig-contribex tl
 - dims # sig-k8s-infra chair
 - nikhita # sig-contribex tl
-- spiffxp # sig-k8s-infra chair
+- upodroid # sig-k8s-infra tl
+- bentheelder # sig-k8s-infra tl
 - thockin
 
 emeritus_approvers:
 - mikedanese
 - bartsmykla
+- spiffxp
 
 labels:
 - sig/k8s-infra
diff --git a/artifacts/OWNERS b/artifacts/OWNERS
index 41bfafc93..0339a2476 100644
--- a/artifacts/OWNERS
+++ b/artifacts/OWNERS
@@ -3,7 +3,7 @@
 options:
   # Root approvers for this repo include contributors who are not involved
   # in artifact promotion. We're blocking root approvals here to ensure
-  # manifests are reviewed by Release Engineering and/or WG K8s Infra
+  # manifests are reviewed by Release Engineering and/or SIG K8s Infra
   # approvers.
   #
   # Long-term, a separate repo has been proposed for these artifact promotion
diff --git a/dns/OWNERS b/dns/OWNERS
index 100c195ff..b402530c9 100644
--- a/dns/OWNERS
+++ b/dns/OWNERS
@@ -3,15 +3,13 @@
 options:
   no_parent_owners: true
 approvers:
-  - ameukam
-  - bentheelder
-  - cblecker
-  - dims
-  - munnerz
-  - spiffxp
+  - sig-k8s-infra-leads
   - thockin
 emeritus_approvers:
   - bartsmykla
+  - spiffxp
+  - cblecker
+  - munnerz
 
 labels:
   - area/dns
diff --git a/groups/OWNERS b/groups/OWNERS
index d7d65ee11..eb4f911f7 100644
--- a/groups/OWNERS
+++ b/groups/OWNERS
@@ -8,11 +8,9 @@ options:
   no_parent_owners: true
 
 approvers:
-- ameukam
 - cblecker
-- dims
 - thockin
-- spiffxp
+- sig-k8s-infra-leads
 - nikhita
 
 reviewers:

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023
@BenTheElder
Copy link
Member Author

done

@k8s-ci-robot k8s-ci-robot added the area/access Define who has access to what via IAM bindings, role bindings, policy, etc. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/groups Google Groups management, code in groups/ size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2023
@ameukam
Copy link
Member

ameukam commented Oct 31, 2023

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit ff6b39a into kubernetes:main Oct 31, 2023
5 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants