Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promoting images with go191 #4230

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

longwuyuan
Copy link
Contributor

@longwuyuan longwuyuan commented Sep 16, 2022

  • Built new images because of bump go to v1.19.1 ingress-nginx#9057
  • Lot of related info is here as well Vulnerability CVE-2022-30580 ingress-nginx#8932
  • This PR promotes the new images that now contain go v1.19.1
  • This PR makes a significant promotion in the test-runner image because that sha has to be updated in the ingress-nginx project's main, for the ingres-nginx-controller's binary to get compiled with go v1.19.1. Reason being the build system uses a docker environ to compile the binary and the docker-environ is built using the test-runner image being promoted here
  • Also changing convention on the tagging for kube-webhook-certgen image and the nginx-errors image because the current tagging convention is not really based on any pre-requisite. So now changed tagging to the registry provided tag that includes a date & some id

/tirage accepted

/assign @tao12345666333 @strongjz @rikatz

@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Sep 16, 2022
@strongjz
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2022
@longwuyuan
Copy link
Contributor Author

/check-cla

1 similar comment
@strongjz
Copy link
Member

/check-cla

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit ce2659f into kubernetes:main Sep 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Sep 16, 2022
@longwuyuan longwuyuan deleted the promote-images-with-go191 branch May 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants