infra/gcp/roles: update custom org roles #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the serviceaccounts are now bound directly to the appropriate roles it seems like including a serviceaccount in a group does not always propogate permissions correctly, so let's stop using it as a pattern
Each permissionRegex is now wrapped in parentheses to become its own group when passed to grep -E. This ensures ^ and $ characters in each regex don't end up applying to the whole | concatenation of regexes.
specifically:
- add comments explaining (or asking) why these roles/permissions
- prune spec:
- roles/browser better captures intent and covers more than
organizationViewer
- roles/iam.securityReviewer covers most storage.buckets permissions
- add to spec:
- roles/cloudasset.viewer in anticipation of using gcloud assets to
list resources and iam roles more quickly for audit
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
specifically - add comments explaining or guessing why these specific roles - add roles/billing.creator to allow creating a budget for k8s-infra-ii-sandbox - add roles/billing.costsManager because it sounds useful - add roles/storage.admin but filter to storage.buckets.* to ensure org admins have break-glass access to buckets
This was referenced May 6, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
#2006 confirms all of the changes here, I reviewed it linking back to commits in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details, but the tl;dr is this should help with:
The groups change also wraps up part of #1974, specifically the part about service accounts being bound directly to their roles rather than indirectly through group membership