Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CephFS Provisioner Addon Fixup #2333

Merged
merged 1 commit into from
Mar 23, 2018
Merged

CephFS Provisioner Addon Fixup #2333

merged 1 commit into from
Mar 23, 2018

Conversation

hswong3i
Copy link
Contributor

Integrate both changes from:

  • Fixup for cephfs_provisioner_namespace
  • Revamp folder structure, so under kubernetes-apps/external_provisioner/cephfs_provisioner (potentially also group local_volume_provisioner under kubernetes-apps/external_provisioner)
  • Some other else minor fixup

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2018
@hswong3i hswong3i mentioned this pull request Feb 14, 2018
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2018
@hswong3i hswong3i force-pushed the cephfs_provisioner_fixup branch 5 times, most recently from c92e867 to e53d57e Compare February 15, 2018 01:45
@hswong3i hswong3i mentioned this pull request Feb 15, 2018
Merged
@hswong3i hswong3i force-pushed the cephfs_provisioner_fixup branch 5 times, most recently from e726f6a to ef2026e Compare February 21, 2018 05:40
@hswong3i hswong3i force-pushed the cephfs_provisioner_fixup branch 2 times, most recently from f327bb4 to 3c3e9ca Compare March 2, 2018 15:41
@hswong3i
Copy link
Contributor Author

hswong3i commented Mar 2, 2018

ping @Atoms need you review it, thanks

@hswong3i hswong3i force-pushed the cephfs_provisioner_fixup branch 3 times, most recently from ef77f86 to de83a22 Compare March 7, 2018 02:06
@hswong3i
Copy link
Contributor Author

hswong3i commented Mar 8, 2018 •
edited
Loading

@Atoms already running this patch in my production for almost 2 weeks and looks stable enough, may you give a hand for review?

@hswong3i hswong3i force-pushed the cephfs_provisioner_fixup branch 2 times, most recently from bb46bde to a0f2c14 Compare March 8, 2018 03:57
@hswong3i
Copy link
Contributor Author

may someone give a hand and so let it go?

@kubernetes-sigs kubernetes-sigs deleted a comment from woopstar Mar 16, 2018
@Atoms
Copy link
Member

Atoms commented Mar 16, 2018

ci check this

@hswong3i
Copy link
Contributor Author

ci not run too...

@hswong3i hswong3i force-pushed the cephfs_provisioner_fixup branch 2 times, most recently from afa3876 to 317058e Compare March 22, 2018 13:34
@hswong3i
Copy link
Contributor Author

@Atoms i had been using this patch for almost a month and all looks good enough for my production, would you mind to give a hand for review?

anyway, CI not running this...

@hswong3i
Copy link
Contributor Author

CI looks good now~

@hswong3i
Copy link
Contributor Author

CI looks good and all pass now~~~

@woopstar woopstar merged commit f077345 into kubernetes-sigs:master Mar 23, 2018
@hswong3i
Copy link
Contributor Author

thanks everyone ;-)

@hswong3i hswong3i deleted the cephfs_provisioner_fixup branch March 24, 2018 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atoms Atoms Atoms approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hswong3i @Atoms @woopstar @k8s-ci-robot