Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Group API reference docs #11194

Merged
merged 1 commit into from
Sep 19, 2024
Merged

📖 Group API reference docs #11194

merged 1 commit into from
Sep 19, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Group API reference docs under a single folder/menu entry

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 17, 2024
fabriziopandini
fabriziopandini commented Sep 17, 2024
View reviewed changes
docs/book/src/reference/api/labels-and-annotations.md Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why git detects this as a new page, but this is just a move of docs/book/src/reference/labels_and_annotations.md + reformat table

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git sometimes has trouble to detect move + diff correctly

@fabriziopandini
Copy link
Member Author

/hold
Adding metadata propagation to this group

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
fabriziopandini
fabriziopandini commented Sep 17, 2024
View reviewed changes
docs/book/src/tasks/experimental-features/cluster-class/operate-cluster.md
@@ -230,7 +230,7 @@ Following recommendation apply:
from one machine to the other.
- Keep machine labels and annotation stable, because changing those values requires machines rollouts;
also, please note that machine labels and annotation are not propagated to Kubernetes nodes; see
[metadata propagation](../../../developer/architecture/controllers/metadata-propagation.md).
[metadata propagation](../../../reference/api/metadata-propagation.md).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fixing the link, but the entire content of this sections seems outdated, I will send a follow-up PR to fix it

@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
sbueringer
sbueringer reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

/approve

docs/book/src/reference/api/owner-references.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@sbueringer
Copy link
Member

Merging to speed this up. If other folks have findings, we'll follow-up with another PR

/lgtm
/appprove

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e5c3bdf3d29c70f1b921d486536ea3616d72693a

@k8s-ci-robot k8s-ci-robot merged commit 649c34d into kubernetes-sigs:main Sep 19, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 19, 2024
@fabriziopandini fabriziopandini deleted the group-API-reference-docs branch September 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @k8s-ci-robot @sbueringer