Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add race option to detect raced codes #10899

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

🐛 Add race option to detect raced codes #10899

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
15b469e
add race option to detect race codes
sivchari Jul 18, 2024
dd2f0f0
fix: race code
sivchari Jul 18, 2024
382edf8
remove -race in test-junit
sivchari Aug 3, 2024
f432f25
add -race
sivchari Aug 20, 2024
567e04f
remove sync variable
sivchari Aug 20, 2024
0e08009
use output that capi sets
sivchari Aug 27, 2024
ddd99a1
use sync chan
sivchari Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove sync variable 
Signed-off-by: sivchari <[email protected]>
  • Loading branch information
@sivchari
sivchari committed Aug 27, 2024
commit 567e04f8bf70a7a24a2cc8cd33b80d5b66d663c0
4 changes: 0 additions & 4 deletions test/infrastructure/inmemory/pkg/runtime/cache/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,8 @@ func (c *cache) startSyncer(ctx context.Context) error {
c.syncQueue.ShutDown()
}()

syncLoopStarted := make(chan struct{})
go func() {
log.Info("Starting sync loop")
syncLoopStarted <- struct{}{}
for {
select {
case <-time.After(c.syncPeriod / 4):
Expand Down Expand Up @@ -81,8 +79,6 @@ func (c *cache) startSyncer(ctx context.Context) error {
wg.Wait()
}()

<-syncLoopStarted

if err := wait.PollUntilContextTimeout(ctx, 50*time.Millisecond, 5*time.Second, false, func(context.Context) (done bool, err error) {
if atomic.LoadInt64(&workers) < int64(c.syncConcurrency) {
return false, nil
Expand Down
Loading