Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for dynamic provisioning #1120

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Add e2e test for dynamic provisioning #1120

merged 1 commit into from
Sep 15, 2023

Conversation

seanzatzdev-amazon
Copy link
Contributor

@seanzatzdev-amazon seanzatzdev-amazon commented Sep 7, 2023

Is this a bug fix or adding new feature?
Adds new e2e test

What is this PR about? / Why do we need it?
This PR adds an e2e test for dynamic provisioning. It simply performs dynamic provisioning, then writes to and reads from the persistent volume to ensure that everything works correctly.

This is important as currently in the EFS-CSI test suite we do not have e2e tests which cover Dynamic Provisioning, and thus we do not have e2e test coverage for EFS-specific CSI Driver features such as "ensureUniqueDirectory". Adding this test allows us more coverage, and will additionally allow us to more easily add further coverage for additional features in the future.

What testing is done?
Test passes on local.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @seanzatzdev-amazon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2023
@Ashley-wenyizha
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2023
@mskanth972
Copy link
Contributor

I think we already have dynamic provisioning e2e test cases link. And also we have a test cases to check the read/write functionality link. Should we need this again?

@seanzatzdev-amazon
Copy link
Contributor Author

seanzatzdev-amazon commented Sep 11, 2023

I think we already have dynamic provisioning e2e test cases link. And also we have a test cases to check the read/write functionality link. Should we need this again?

Hey Shashi, what you say is true. Though the dynamic provisioning definition you linked is intended to be used by the kubernetes e2e tests which as I understand do not test EFS-specific features (such as storage class features like subpath pattern, reusingAccessPoints, etc). The reading/writing is also tested currently but for static provisioning.

Combining both of these aspects into a new EFS-specific e2e test will allow us to add more robustness in the tests later on.

@mskanth972
Copy link
Contributor

I think we already have dynamic provisioning e2e test cases link. And also we have a test cases to check the read/write functionality link. Should we need this again?

Hey Shashi, what you say is true. Though the dynamic provisioning definition you linked is intended to be used by the kubernetes e2e tests which as I understand do not test EFS-specific features (such as storage class features like subpath pattern, reusingAccessPoints, etc). The reading/writing is also tested currently but for static provisioning.

Combining both of these aspects into a new EFS-specific e2e test will allow us to add more robustness in the tests later on.

Okay, it makes sense.

@mskanth972
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@mskanth972
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mskanth972, seanzatzdev-amazon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 18828a0 into kubernetes-sigs:master Sep 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants