-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for dynamic provisioning #1120
Add e2e test for dynamic provisioning #1120
Conversation
Hi @seanzatzdev-amazon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hey Shashi, what you say is true. Though the dynamic provisioning definition you linked is intended to be used by the kubernetes e2e tests which as I understand do not test EFS-specific features (such as storage class features like subpath pattern, reusingAccessPoints, etc). The reading/writing is also tested currently but for static provisioning. Combining both of these aspects into a new EFS-specific e2e test will allow us to add more robustness in the tests later on. |
Okay, it makes sense. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Adds new e2e test
What is this PR about? / Why do we need it?
This PR adds an e2e test for dynamic provisioning. It simply performs dynamic provisioning, then writes to and reads from the persistent volume to ensure that everything works correctly.
This is important as currently in the EFS-CSI test suite we do not have e2e tests which cover Dynamic Provisioning, and thus we do not have e2e test coverage for EFS-specific CSI Driver features such as "ensureUniqueDirectory". Adding this test allows us more coverage, and will additionally allow us to more easily add further coverage for additional features in the future.
What testing is done?
Test passes on local.