Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kserve manifests from v0.11.2 (#2627) and synchronize from the 1.8 branch #2633

Merged

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Feb 29, 2024

@rimolive

cherry pick Update kubeflow/kubeflow manifests from v1.8.0 (#2567)

* Update kubeflow/kubeflow manifests from v1.8.0 (#2567)

Signed-off-by: juliusvonkohout <[email protected]>

* Update kserve manifests from v0.11.2

Update kserve/kserve manifests from v0.11.2

Signed-off-by: Ricardo M. Oliveira <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>

* Update install_cert_manager.sh

Signed-off-by: juliusvonkohout <[email protected]>

---------

Signed-off-by: juliusvonkohout <[email protected]>
Signed-off-by: Ricardo M. Oliveira <[email protected]>
Co-Authored-By: Daniela Plascencia <[email protected]>
Co-Authored-By: Julius von Kohout <[email protected]>
@juliusvonkohout juliusvonkohout changed the title Update kserve manifests from v0.11.2 (#2627) Update kserve manifests from v0.11.2 (#2627) and synchronize from the 1.8 branch Feb 29, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Feb 29, 2024

We should drop

# If you want to install both KFServing and KServe, install the
# standalone kserve manifests, to avoid conflicts with 0.6.1 KFServing.
# - kserve.yaml
# - aggregated-roles.yaml
# - kserve-runtimes.yaml
# configMapGenerator:
#   - name: kserve-config
#     namespace: kserve
#     behavior: merge
#     envs:
#     - params.env

from the main kustomization.yaml since KFserving is gone.

https://github.com/kubeflow/manifests/blob/7c2de6bbfd486919b36d519f08393399758c30c8/tests/gh-actions/install_kserve.sh should be rewritten to clearly separate the CRD installation and wait after that.

@rimolive
Copy link
Member

Is this required for 1.8.1?

@juliusvonkohout
Copy link
Member Author

Is this required for 1.8.1?

no for 1.9. The merge just started the wrong way. we should always update master first and backport to older branches as for example 1.8. So this time i have to make a forward-port.

@juliusvonkohout juliusvonkohout merged commit 39bac59 into master Mar 1, 2024
8 of 9 checks passed
@juliusvonkohout juliusvonkohout deleted the synchronize-1.8-to-master-(kserve-and-doumentation) branch March 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update the KServe to the version 0.11.2
2 participants