h264: don't write to source picture object in ff_h264_ref_picture().

Doing so is analogous to writing to source data in memcpy(), and causes (harmless) tsan warnings in fate-h264.
ksvc · Mar 31, 2017 · b5300c8 · b5300c8
1 parent 081c21c
commit b5300c8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c
@@ -70,8 +70,8 @@ int ff_h264_ref_picture(H264Context *h, H264Picture *dst, H264Picture *src)
 
     av_assert0(!dst->f->buf[0]);
     av_assert0(src->f->buf[0]);
+    av_assert0(src->tf.f == src->f);
 
-    src->tf.f = src->f;
     dst->tf.f = dst->f;
     ret = ff_thread_ref_frame(&dst->tf, &src->tf);
     if (ret < 0)