Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build system and refactor project conguration #9

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

cstub
Copy link
Collaborator

@cstub cstub commented Feb 4, 2022

  • Use Flit as build backend in favour of setuptools
  • Make project installable in editable mode for local development
  • Consolidate all project dependencies and project configuration in pyproject.toml
  • Create invoke tasks for the most common development tasks
  • Enable flake8 code checks and add config file
  • Enable single-quote substitution by black

* Use `Flit` as build backend in favour of `setuptools`
* Make project installable in editable mode for local development
* Consolidate all project dependencies and project configuration in `pyproject.toml`
* Create `invoke` tasks for the most common development tasks
* Enable `flake8` code checks and add config file
* Enable single-quote substitution by `black`
Copy link
Owner

@krasserm krasserm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, awesome PR! Many thanks @cstub for your great contribution. I only had a few minor nitpicks.

tests/test_lightning.py Outdated Show resolved Hide resolved
tasks.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@krasserm krasserm merged commit c4d50d3 into main Feb 7, 2022
@krasserm krasserm deleted the wip-project-template branch February 7, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants