Basic raster dataset import #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-use tile import code from point-cloud - plus some new metadata extraction code using gdalinfo - to get the import of a GeoTIFF working, and add a unit test. Any kind of conversion during import (ie, convert-to-cog) is not supported. Extraction of color-tables / category-tables (which should be part of the schema) is not yet supported. Detection of COG vs non-COG is not yet supported. Exact storage of envelopes, file-format etc is still up in the air. The file-system WC has not yet been modified to check out this type of dataset.
craigds
reviewed
Feb 23, 2023
| # Raster imports: | ||
| ImportSourceType( | ||
| "GeoTIFF", | ||
| "PATH.tif or PATH.tiff", |
There was a problem hiding this comment.
this is a human-readable filename suggestion? normally everyone uses .tif, i'd just drop the .tiff one
There was a problem hiding this comment.
Not done - it's not hurting anyone and we do accept .tif or .tiff files
craigds
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-use tile import code from point-cloud -
plus some new metadata extraction code using gdalinfo - to get the import of a GeoTIFF working, and add a unit test.
Any kind of conversion during import (ie, convert-to-cog) is not supported. Extraction of color-tables / category-tables (which should be part of the schema) is not yet supported.
Detection of COG vs non-COG is not yet supported.
Exact storage of envelopes, file-format etc is still up in the air. The file-system WC has not yet been modified to check out this type of dataset.
#565
Checklist: