Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kart data ls, kart data version #892

Open
olsen232 opened this issue Jul 28, 2023 · 0 comments
Open

Improve kart data ls, kart data version #892

olsen232 opened this issue Jul 28, 2023 · 0 comments

Comments

@olsen232
Copy link
Collaborator

Since Kart 0.12, Kart repositories are not homogenous: there is now more than one type of dataset.
Supported datasets are table (v3), point cloud (v1) and raster (v1).

The command kart data ls shows you a list of datasets in the current repository, but, doesn't show you what type of dataset they are, or what version.
(By contrast, the command kart meta get --with-dataset-types does show you this information.)

The command kart data version basically always tells you "This Kart repo uses Datasets v3"
When only table datasets existed and there was a high chance of finding v1 or v2 table datasets, this command was useful.
This command hasn't been updated to deal with new types of dataset - it always shows you the the table-dataset version is, which is a repository wide setting. Repository-wide dataset version settings is something we've since moved away from as the new dataset types were added.

Now that there are multiple types of dataset, but not currently lots of different versions of them, this command should either go away, or, show you basically exactly the same information that kart data ls will once it shows you the types and versions.
(Need to make sure none of the current clients on the exact output of these commands before making changes.)

olsen232 added a commit that referenced this issue Jul 31, 2023
Backwards compatible at this point:
- You need to add a flag to change kart-data-ls behaviour
- kart-data-version is now deprecated, but still works.

See #892
olsen232 added a commit that referenced this issue Jul 31, 2023
Backwards compatible at this point:
- You need to add a flag to change kart-data-ls behaviour
- kart-data-version is now deprecated, but still works.

See #892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant