Support existing resources without annotations #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get a failure in the case where I am applying a stack that has a resource in it that - exists in the cluster (maybe created with some other process) - has no annotations. Pharos errors in such a case with `ERROR: NoMethodError : undefined method `[]' for nil:NilClass`
jnummelin
suggested changes
Feb 19, 2019
Co-Authored-By: captncraig <[email protected]>
jnummelin
approved these changes
Feb 19, 2019
|
Rubocop is not happy. |
|
@captncraig could you fix the rubocop error? (see https://travis-ci.com/kontena/k8s-client/jobs/178815291#L865) |
|
Similar fix: #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get a failure in the case where I am applying a stack that has a resource in it that
Pharos errors in such a case with
ERROR: NoMethodError : undefined method[]' for nil:NilClass`This change will allow pharos to begin managing such a resource even though the checksum does not exist at first.