Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require PHP7.4 #1326

Merged
merged 1 commit into from
Jun 5, 2021
Merged

feat: require PHP7.4 #1326

merged 1 commit into from
Jun 5, 2021

Conversation

phanan
Copy link
Member

@phanan phanan commented Jun 4, 2021

PHP 7.4 has been released a year and a half ago. Time to upgrade.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #1326 (cb12f16) into master (d30c598) will increase coverage by 0.14%.
The diff coverage is 75.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1326      +/-   ##
============================================
+ Coverage     70.49%   70.63%   +0.14%     
+ Complexity      481      480       -1     
============================================
  Files            89       88       -1     
  Lines          1403     1369      -34     
============================================
- Hits            989      967      -22     
+ Misses          414      402      -12     
Impacted Files Coverage Δ
app/Factories/StreamerFactory.php 100.00% <ø> (ø)
app/Helpers.php 81.25% <0.00%> (+4.77%) ⬆️
app/Http/Controllers/API/AlbumCoverController.php 100.00% <ø> (ø)
.../Http/Controllers/API/AlbumThumbnailController.php 100.00% <ø> (ø)
app/Http/Controllers/API/ArtistImageController.php 100.00% <ø> (ø)
app/Http/Controllers/API/AuthController.php 0.00% <ø> (ø)
app/Http/Controllers/API/DataController.php 0.00% <ø> (ø)
...pp/Http/Controllers/API/Interaction/Controller.php 100.00% <ø> (ø)
...llers/API/Interaction/RecentlyPlayedController.php 0.00% <ø> (ø)
app/Http/Controllers/API/LastfmController.php 100.00% <ø> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30c598...cb12f16. Read the comment docs.

@cypress
Copy link

cypress bot commented Jun 4, 2021



Test summary

104 4 0 0Flakiness 7


Run details

Project koel
Status Failed
Commit cb12f16
Started Jun 4, 2021 10:38 PM
Ended Jun 4, 2021 10:41 PM
Duration 03:07 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Failures

albums.spec.ts Failed
1 Albums > invokes artist screen
artists.spec.ts Failed
1 Artists > loads the list of artists
2 Artists > plays all songs by an artist
favorites.spec.ts Failed
1 Favorites > deletes a favorite with Backspace key

Flakiness

albums.spec.ts Flakiness
1 Albums > loads the list of albums
2 Albums > changes display mode
artists.spec.ts Flakiness
1 Artists > changes display mode
queuing.spec.ts Flakiness
1 Queuing > navigates through the queue
2 Queuing > rotates if reaches end of queue in repeat-all mode
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@phanan phanan merged commit 70696da into master Jun 5, 2021
@phanan phanan deleted the php74 branch June 5, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants