simplify net-gateway-api install

[dprotaso]

Include gateway apis's istio as part of the single one shot kapp install for our e2e tests

[dprotaso]

/assign @nak3

[codecov]

Codecov Report

Merging #12386 (935034e) into main (50e4b64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12386   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files         195      195           
  Lines        9655     9655           
=======================================
  Hits         8440     8440           
- Misses        931      932    +1     
+ Partials      284      283    -1     

Impacted Files	Coverage Δ
pkg/activator/net/revision_backends.go	91.73% <0.00%> (-0.87%)	⬇️
pkg/reconciler/configuration/configuration.go	86.15% <0.00%> (+1.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e4b64...935034e. Read the comment docs.

[dprotaso]

Need to fix the actions

[dprotaso]

/test pull-knative-serving-gateway-api-latest

[dprotaso]

/test pull-knative-serving-gateway-api-latest

[dprotaso]

/hold going to test the kind setup locally

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/test pull-knative-serving-gateway-api-latest

[nak3]

LGTM. But honestly this ytt & kapp script is too difficult for me to read and I have no confidence to maintain this script.
In fact, I spent so much time to figure out this bug carvel-dev/kapp#381 .

I would like someone who can read this ytt script to review&lgtm 🙏

[dprotaso]

The setup happens in two phases

Gather the necessary yamls we require in knative_setup - info here

serving/test/e2e-common.sh

Lines 170 to 194 in 420a599

	# Gather all the YAML we require to run all our tests.
	# We stage these files into ${E2E_YAML_DIR}
	#
	# > serving built from HEAD > $E2E_YAML_DIR/serving/HEAD/install
	# > $E2E_YAML_DIR/serving/HEAD/post-install
	#
	# > serving latest-release > $E2E_YAML_DIR/serving/latest-release/install
	# > $E2E_YAML_DIR/serving/latest-release/post-install
	#
	# > net-istio HEAD > $E2E_YAML_DIR/istio/HEAD/install
	# > net-istio latest-release > $E2E_YAML_DIR/istio/latest-release/install
	#
	# We download istio.yaml for our given test profile (ie. mesh on kind).
	# The files downloaded are istio.yaml & config-istio.yaml.
	#
	# config-istio.yaml is to be applied _after_ we install net-istio.yaml since
	# it includes profile specific configuration
	#
	# > test/config/**.yaml > $E2E_YAML_DIR/serving/test/config
	#
	# These resources will be passed through `ko` if there exists a `ko://`
	# strict reference. Secondly namespace overlays will be applied to place
	# them in the correct
	#
	function knative_setup() {

install just selects which files to pass to ytt. The result from ytt is use by kapp to do the install.

This solves your issue because we're installing istio using kapp now vs. istioctl install.

[dprotaso]

/hold cancel

[nak3]

/lgtm