Allow users to set containers[*].securityContext.runAsGroup #12003
Conversation
knative-prow-robot
added
size/S
dprotaso
changed the title
dprotaso
force-pushed
the
security-context
branch
from
6d58764
to
9063864
Compare
Codecov Report
@@ Coverage Diff @@
## main #12003 +/- ##
==========================================
- Coverage 87.54% 87.53% -0.02%
==========================================
Files 196 196
Lines 9506 9503 -3
==========================================
- Hits 8322 8318 -4
- Misses 912 913 +1
Partials 272 272
Continue to review full report at Codecov.
|
…tion Most of them you can set and we shouldn't advertise setting RunAsNonRoot=false since it behaves the same when the field is not set
|
/retest |
|
/assign @julz @markusthoemmes |
There was a problem hiding this comment.
LGTM but given that the discussion seems to still be open want to let others weigh in
| if in.RunAsNonRoot != nil && *in.RunAsNonRoot { | ||
| out.RunAsNonRoot = in.RunAsNonRoot | ||
| } |
There was a problem hiding this comment.
IIRC we had some reason to only allow true through here. You sure that's not necessary?
There was a problem hiding this comment.
Left a comment below regarding this
// RunAsNonRoot when unset behaves the same way as false
// We do want the ability for folks to set this value to true
There was a problem hiding this comment.
I think we were worried that people may have defaulted runAsNonRoot to true, in which case allowing it to be false would be a security regression. I think the PSP doesn't allow you to default runAsNonRoot though (it just has a MustRunAsNonRoot setting instead) so this might be fine.
There was a problem hiding this comment.
.. in fact it's a straight boolean and not a pointer, so it can't really be defaulted any way other than false
knative-prow-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, julz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold me fine. |
knative-prow-robot
removed
the
do-not-merge/hold
Part of: #9067
Release Note