Remove the upscaling of the voxel size in shrink-wrap #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The ShrinkWrap tightens the convex hulls to reduce the conservativeness of the convex hulls compared to the original geometry. But it also results in "leakage" of the original geometry, that is in some areas the convex hull shrinks too much and becomes less conservative than the original geometry as shown in the left image below.
Solution:
As the distance threshold parameter of the shrinkwrap, the voxel size scaled by factor of 4 is passed. It is not clear to me why that is. But removing that factor, and therefore using a smaller distance threshold seems to reduce the leakage as shown in the right image below.