Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the upscaling of the voxel size in shrink-wrap #154

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

neemoh
Copy link

@neemoh neemoh commented Dec 14, 2023

Issue:
The ShrinkWrap tightens the convex hulls to reduce the conservativeness of the convex hulls compared to the original geometry. But it also results in "leakage" of the original geometry, that is in some areas the convex hull shrinks too much and becomes less conservative than the original geometry as shown in the left image below.

Solution:
As the distance threshold parameter of the shrinkwrap, the voxel size scaled by factor of 4 is passed. It is not clear to me why that is. But removing that factor, and therefore using a smaller distance threshold seems to reduce the leakage as shown in the right image below.

image

@jratcliff63367 jratcliff63367 merged commit 90ea9ca into kmammou:master Dec 14, 2023
@jratcliff63367
Copy link
Collaborator

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants