Skip to content

Commit

Permalink
lib: allow memparse() to accept a NULL and ignorable second parm
Browse files Browse the repository at this point in the history
Extend memparse() to allow the caller to use a NULL second parameter, which
would represent no interest in returning the address of the end of the parsed
string.

In numerous cases, callers invoke memparse() to parse a possibly-suffixed
string (such as "64K" or "2G" or whatever) and define a character pointer to
accept the end pointer being returned by memparse() even though they have no
interest in it and promptly throw it away.

This (backward-compatible) enhancement allows callers to use NULL in the cases
where they just don't care about getting back that end pointer.

[[email protected]: coding-style fixes]
Signed-off-by: Robert P. J. Day <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
rpjday authored and torvalds committed Jul 25, 2008
1 parent cb345d7 commit fd19382
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions lib/cmdline.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ char *get_options(const char *str, int nints, int *ints)
/**
* memparse - parse a string with mem suffixes into a number
* @ptr: Where parse begins
* @retptr: (output) Pointer to next char after parse completes
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
* potentially suffixed with %K (for kilobytes, or 1024 bytes),
Expand All @@ -126,11 +126,13 @@ char *get_options(const char *str, int nints, int *ints)
* megabyte, or one gigabyte, respectively.
*/

unsigned long long memparse (char *ptr, char **retptr)
unsigned long long memparse(char *ptr, char **retptr)
{
unsigned long long ret = simple_strtoull (ptr, retptr, 0);
char *endptr; /* local pointer to end of parsed string */

switch (**retptr) {
unsigned long long ret = simple_strtoull(ptr, &endptr, 0);

switch (*endptr) {
case 'G':
case 'g':
ret <<= 10;
Expand All @@ -140,10 +142,14 @@ unsigned long long memparse (char *ptr, char **retptr)
case 'K':
case 'k':
ret <<= 10;
(*retptr)++;
endptr++;
default:
break;
}

if (retptr)
*retptr = endptr;

return ret;
}

Expand Down

0 comments on commit fd19382

Please sign in to comment.