-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
checkkconfigsymbols.py: avoid shell injection
Use subprocess and set shell to False to avoid potential shell injections. Reported-by: Bernd Dietzel <[email protected]> Signed-off-by: Valentin Rothberg <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
- Loading branch information
Showing
1 changed file
with
7 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
"""Find Kconfig symbols that are referenced but not defined.""" | ||
|
||
# (c) 2014-2015 Valentin Rothberg <[email protected]> | ||
# (c) 2014-2016 Valentin Rothberg <[email protected]> | ||
# (c) 2014 Stefan Hengelein <[email protected]> | ||
# | ||
# Licensed under the terms of the GNU GPL License version 2 | ||
|
@@ -12,6 +12,7 @@ | |
import os | ||
import re | ||
import signal | ||
import subprocess | ||
import sys | ||
from multiprocessing import Pool, cpu_count | ||
from optparse import OptionParser | ||
|
@@ -222,10 +223,11 @@ def red(string): | |
|
||
def execute(cmd): | ||
"""Execute %cmd and return stdout. Exit in case of error.""" | ||
pop = Popen(cmd, stdout=PIPE, stderr=STDOUT, shell=True) | ||
(stdout, _) = pop.communicate() # wait until finished | ||
if pop.returncode != 0: | ||
sys.exit(stdout) | ||
try: | ||
cmdlist = cmd.split(" ") | ||
stdout = subprocess.check_output(cmdlist, stderr=STDOUT, shell=False) | ||
except subprocess.CalledProcessError as fail: | ||
exit("Failed to execute %s\n%s" % (cmd, fail)) | ||
return stdout | ||
|
||
|
||
|