Skip to content

Commit

Permalink
Merge branch 'core-fixes-for-linus' of git://git.kernel.org/pub/scm/l…
Browse files Browse the repository at this point in the history
…inux/kernel/git/tip/linux-2.6-tip

* 'core-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  dma-debug: Fix check_unmap null pointer dereference
  • Loading branch information
torvalds committed Aug 25, 2009
2 parents 44afa9a + ec9c96e commit 87bcfa3
Showing 1 changed file with 16 additions and 12 deletions.
28 changes: 16 additions & 12 deletions lib/dma-debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,13 @@ static bool driver_filter(struct device *dev)
return true;

/* driver filter on and initialized */
if (current_driver && dev->driver == current_driver)
if (current_driver && dev && dev->driver == current_driver)
return true;

/* driver filter on, but we can't filter on a NULL device... */
if (!dev)
return false;

if (current_driver || !current_driver_name[0])
return false;

Expand All @@ -183,17 +187,17 @@ static bool driver_filter(struct device *dev)
return ret;
}

#define err_printk(dev, entry, format, arg...) do { \
error_count += 1; \
if (driver_filter(dev) && \
(show_all_errors || show_num_errors > 0)) { \
WARN(1, "%s %s: " format, \
dev_driver_string(dev), \
dev_name(dev) , ## arg); \
dump_entry_trace(entry); \
} \
if (!show_all_errors && show_num_errors > 0) \
show_num_errors -= 1; \
#define err_printk(dev, entry, format, arg...) do { \
error_count += 1; \
if (driver_filter(dev) && \
(show_all_errors || show_num_errors > 0)) { \
WARN(1, "%s %s: " format, \
dev ? dev_driver_string(dev) : "NULL", \
dev ? dev_name(dev) : "NULL", ## arg); \
dump_entry_trace(entry); \
} \
if (!show_all_errors && show_num_errors > 0) \
show_num_errors -= 1; \
} while (0);

/*
Expand Down

0 comments on commit 87bcfa3

Please sign in to comment.