Skip to content

Commit

Permalink
firewire net: No need to reset dev->local_fifo after failure of fw_co…
Browse files Browse the repository at this point in the history
…re_add_address_handler().

fwnet_broadcast_start() try to register address handler at first
if it was not registered yet; dev->local_fifo ==
FWNET_NO_FIFO_ADDR.

Since dev->local_info not changed if fw_core_add_address_hander()
has failed, we do not need to set dev->local_info to
FWNET_NO_FIFO_ADDR.

Signed-off-by: YOSHIFUJI Hideaki <[email protected]>
Signed-off-by: Stefan Richter <[email protected]>
  • Loading branch information
yoshfuji authored and Stefan Richter committed Mar 13, 2013
1 parent 6dbe51c commit 5104a03
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/firewire/net.c
Original file line number Diff line number Diff line change
Expand Up @@ -1220,8 +1220,8 @@ static int fwnet_broadcast_start(struct fwnet_device *dev)
dev->broadcast_rcv_context = NULL;
failed_context_create:
fw_core_remove_address_handler(&dev->handler);
failed_initial:
dev->local_fifo = FWNET_NO_FIFO_ADDR;
failed_initial:

return retval;
}
Expand Down

0 comments on commit 5104a03

Please sign in to comment.