Skip to content

Commit

Permalink
netlink: Do not subscribe to non-existent groups
Browse files Browse the repository at this point in the history
[ Upstream commit 7acf9d4237c46894e0fa0492dd96314a41742e84 ]

Make ABI more strict about subscribing to group > ngroups.
Code doesn't check for that and it looks bogus.
(one can subscribe to non-existing group)
Still, it's possible to bind() to all possible groups with (-1)

Cc: "David S. Miller" <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: Steffen Klassert <[email protected]>
Cc: [email protected]
Signed-off-by: Dmitry Safonov <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
0x7f454c46 authored and gregkh committed Aug 9, 2018
1 parent f4a9db5 commit 4f08437
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/netlink/af_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,7 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
if (err)
return err;
}
groups &= (1UL << nlk->ngroups) - 1;

bound = nlk->bound;
if (bound) {
Expand Down

0 comments on commit 4f08437

Please sign in to comment.