Skip to content

Commit

Permalink
tty: xuartps: Keep lock for whole ISR
Browse files Browse the repository at this point in the history
The RX path in the interrupt handler released a lock unnecessarily.

Signed-off-by: Soren Brinkmann <[email protected]>
Reviewed-by: Peter Hurley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
sorenb-xlnx authored and gregkh committed Feb 7, 2016
1 parent 6e14f7c commit 4c0b92e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/tty/serial/xilinx_uartps.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
uart_insert_char(port, isrstatus, CDNS_UART_IXR_OVERRUN,
data, status);
}
spin_unlock(&port->lock);
tty_flip_buffer_push(&port->state->port);
spin_lock(&port->lock);
}

/* Dispatch an appropriate handler */
Expand Down

0 comments on commit 4c0b92e

Please sign in to comment.