Skip to content

Commit

Permalink
MIPS: Fix global namespace pollution in arch/mips/kernel/smp-up.c
Browse files Browse the repository at this point in the history
The following symbols in arch/mips/kernel/smp-up.c are needlessly
defined global:

up_send_ipi_single()
up_init_secondary()
up_smp_finish()
up_cpus_done()
up_boot_secondary()
up_smp_setup()
up_prepare_cpus()

This patch makes the symbols static.

Build-tested using malta_defconfig.

Signed-off-by: Dmitri Vorobiev <[email protected]>
Signed-off-by: Ralf Baechle <[email protected]>
  • Loading branch information
dmvo authored and ralfbaechle committed Mar 30, 2009
1 parent d0cdfe2 commit 1451a39
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions arch/mips/kernel/smp-up.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/*
* Send inter-processor interrupt
*/
void up_send_ipi_single(int cpu, unsigned int action)
static void up_send_ipi_single(int cpu, unsigned int action)
{
panic(KERN_ERR "%s called", __func__);
}
Expand All @@ -27,31 +27,31 @@ static inline void up_send_ipi_mask(cpumask_t mask, unsigned int action)
* After we've done initial boot, this function is called to allow the
* board code to clean up state, if needed
*/
void __cpuinit up_init_secondary(void)
static void __cpuinit up_init_secondary(void)
{
}

void __cpuinit up_smp_finish(void)
static void __cpuinit up_smp_finish(void)
{
}

/* Hook for after all CPUs are online */
void up_cpus_done(void)
static void up_cpus_done(void)
{
}

/*
* Firmware CPU startup hook
*/
void __cpuinit up_boot_secondary(int cpu, struct task_struct *idle)
static void __cpuinit up_boot_secondary(int cpu, struct task_struct *idle)
{
}

void __init up_smp_setup(void)
static void __init up_smp_setup(void)
{
}

void __init up_prepare_cpus(unsigned int max_cpus)
static void __init up_prepare_cpus(unsigned int max_cpus)
{
}

Expand Down

0 comments on commit 1451a39

Please sign in to comment.