Skip to content

Commit

Permalink
pkt_sched: Fix locking in shutdown_scheduler_queue()
Browse files Browse the repository at this point in the history
Qdisc locks need to be held with BH disabled.

Tested-by: Ingo Molnar <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
davem330 committed Jul 25, 2008
1 parent f867e6a commit cffe1c5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/sched/sch_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -736,9 +736,9 @@ static void shutdown_scheduler_queue(struct net_device *dev,
dev_queue->qdisc = qdisc_default;
dev_queue->qdisc_sleeping = qdisc_default;

spin_lock(root_lock);
spin_lock_bh(root_lock);
qdisc_destroy(qdisc);
spin_unlock(root_lock);
spin_unlock_bh(root_lock);
}
}

Expand Down

0 comments on commit cffe1c5

Please sign in to comment.