Skip to content

Commit

Permalink
ieee1394: nodemgr: fix startup of knodemgrd
Browse files Browse the repository at this point in the history
Revert a thinko in commit d2f119f:
When knodemgrd starts, it needs to sleep until host->generation was
incremented above its initial value of 0.  My wrong logic caused it to
start sending requests when the bus wasn't completely ready.  Seen as
"AT dma reset ctx=0, aborting transmission" messages in 2.6.19-rc1.

Signed-off-by: Stefan Richter <[email protected]>
  • Loading branch information
Stefan Richter committed Oct 8, 2006
1 parent 3253b66 commit b7a7179
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ieee1394/nodemgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -1614,7 +1614,7 @@ static int nodemgr_host_thread(void *__hi)
{
struct host_info *hi = (struct host_info *)__hi;
struct hpsb_host *host = hi->host;
unsigned int g, generation = get_hpsb_generation(host) - 1;
unsigned int g, generation = 0;
int i, reset_cycles = 0;

/* Setup our device-model entries */
Expand Down

0 comments on commit b7a7179

Please sign in to comment.